Add Status API support with BackOffLimit API #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souravbiswassanto
force-pushed
the
phase-support
branch
6 times, most recently
from
edd5b3c to
0a05039
Compare
| } | ||
|
|
||
| // SidekickStatus defines the observed state of Sidekick | ||
| type SidekickStatus struct { | ||
| Leader LeaderStatus `json:"leader"` | ||
| Pod core.PodPhase `json:"pod"` | ||
| Leader LeaderStatus `json:"leader,omitempty"` |
There was a problem hiding this comment.
Need review here. Removing this field as required.
souravbiswassanto
force-pushed
the
phase-support
branch
3 times, most recently
from
661e987 to
a015046
Compare
souravbiswassanto
force-pushed
the
phase-support
branch
from
a015046 to
12aadfd
Compare
Signed-off-by: souravbiswassanto <[email protected]>
souravbiswassanto
force-pushed
the
phase-support
branch
from
12aadfd to
8b67c33
Compare
Signed-off-by: Arnob Kumar Saha <[email protected]>
Signed-off-by: Arnob Kumar Saha <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
ArnobKumarSaha
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: souravbiswassanto [email protected]